This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Don't try to copy items by serializing and deserializing them #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234
Previously, when splitting an item using its tab's context menu, if the item did not have a
.copy()method, we would try to copy the item by serializing it and then deserializing the serialized state. The problem with this is that for some items (e.g. the tree-view), deserialization always returns the same instance.I think it's more explicit for copyable items to just implement a
.copy()method. Before releasing this change, I need to add a.copymethod to some of Atom's pane item classes: